Skip to content

chore: remove pingWebSocket since yamux runs keepalives #11914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2024
Merged

chore: remove pingWebSocket since yamux runs keepalives #11914

merged 1 commit into from
Feb 1, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Jan 30, 2024 •
edited
Loading

Since we run yamux over the websocket, we don't need to ping at the websocket layer because yamux has a 30 second keepalive mechanism enabled in the default config.

@spikecurtis spikecurtis mentioned this pull request Jan 30, 2024
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Jan 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis marked this pull request as ready for review January 30, 2024 10:25
@spikecurtis spikecurtis force-pushed the spike/10534-no-websocket-pings branch from 6565cbc to 3fe1072 Compare January 30, 2024 10:44
@spikecurtis spikecurtis mentioned this pull request Jan 30, 2024
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Feb 1, 2024 •
edited
Loading

Merge activity

  • Jan 31, 11:21 PM EST America/New_York: @spikecurtis started a stack merge that includes this pull request via Graphite.
  • Jan 31, 11:23 PM EST America/New_York: Graphite rebased this pull request as part of a merge.
  • Jan 31, 11:31 PM EST America/New_York: Graphite couldn't merge this PR because it was not satisfying all requirements.
  • Feb 1, 12:48 AM EST America/New_York: @spikecurtis merged this pull request with Graphite.

Base automatically changed from spike/10534-remove-rpc-method to main February 1, 2024 04:22
@spikecurtis spikecurtis force-pushed the spike/10534-no-websocket-pings branch from 3fe1072 to 670785e Compare February 1, 2024 04:22
@spikecurtis spikecurtis force-pushed the spike/10534-no-websocket-pings branch from 670785e to 6929b62 Compare February 1, 2024 05:40
@spikecurtis spikecurtis merged commit 073d1f7 into main Feb 1, 2024
@spikecurtis spikecurtis deleted the spike/10534-no-websocket-pings branch February 1, 2024 05:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

@deansheather deansheather Awaiting requested review from deansheather

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @coadler