Skip to content

fix(cli): allow template name length of 32 in template push and create #11915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix(cli): allow template name length of 32 in template push and create #11915

merged 1 commit into from
Jan 30, 2024

Conversation

mafredri
Copy link
Member

@mafredri mafredri self-assigned this Jan 30, 2024
@mafredri mafredri requested review from johnstcn and mtojek January 30, 2024 10:33
johnstcn
johnstcn reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The db schema specifies character varying(64), so why not go higher? It's free real estate!

@mafredri
Copy link
Member Author

The db schema specifies character varying(64), so why not go higher? It's free real estate!

Unfortunately our schema and API are a wild-west and not synchronized, afraid API constrains this to 32 characters.

@johnstcn
Copy link
Member

The db schema specifies character varying(64), so why not go higher? It's free real estate!

Unfortunately our schema and API are a wild-west and not synchronized, afraid API constrains this to 32 characters.

😿

@johnstcn johnstcn self-requested a review January 30, 2024 10:45
@mafredri mafredri merged commit 60653bb into main Jan 30, 2024
@mafredri mafredri deleted the mafredri/fix-cli-templatepush branch January 30, 2024 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @mtojek