feat: add statsReporter for reporting stats on agent v2 API #11920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
mafredri
reviewed
Jan 30, 2024
| req := testutil.RequireRecvCtx(ctx, t, fDest.reqs) | ||
| require.NotNil(t, req) | ||
| require.Nil(t, req.Stats) | ||
| interval := time.Second * 34 |
There was a problem hiding this comment.
Is there a special meaning to this magic value?
There was a problem hiding this comment.
I just wanted something that's not likely to be some internal constant and proves that we actually use the interval in the response.
11f3d11 to
8c43c94
Compare
mafredri
approved these changes
Jan 31, 2024
| return xerrors.Errorf("initial update: %w", err) | ||
| } | ||
| s.lastInterval = resp.ReportInterval.AsDuration() | ||
| s.source.SetConnStatsCallback(s.lastInterval, maxConns, s.callback) |
There was a problem hiding this comment.
Would it make sense to also unset the callback on exit? Mostly a safety precaution in case callback ever has code that may block without a consumer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new statsReporter subcomponent of the agent, which in a later PR will be used to report stats over the v2 API.
Refactors the logic a bit so that we can handle starting and stopping stats reporting if the agent API connection drops and reconnects.