Skip to content

chore: update storybook #11936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2024
Merged

chore: update storybook #11936

merged 3 commits into from
Jan 30, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 30, 2024

  • Update Storybook to 7.6

  • This version adds a new --test build flag which supposedly makes CI builds "2-4x" faster. I am skeptic, but faster CI is always a good thing, so as long as it isn't slower I say we go for it.

  • Replace old/experimental testing packages with the new, stable, @storybook/test. Their getting started docs still tell you to use the old ones, so I missed that there's already a new/preferred/"more performant"/stable package you're supposed to use instead.

  • Upload the build as a .zip, rather than individual files. One compressed upload can be much faster than many sequential uploads.


Trying to gather a little data about build times:

Prior New
5m 44s 1m 43s
3m 21s
3m 28s
3m 35s
5m 12s

Chromatic seems to do weird things when you rerun it on the same commit, so it's hard to get more than one data point for the speed-up, but it seems promising.

@aslilac aslilac merged commit aeb4112 into main Jan 30, 2024
@aslilac aslilac deleted the update-storybook branch January 30, 2024 21:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants