Skip to content

feat: add custom error message on signups disabled page #11959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 1, 2024
Merged

feat: add custom error message on signups disabled page #11959

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5cdf612
feat: custom error message on signups disabled page
mtojek Jan 31, 2024
66ee205
yaml
mtojek Jan 31, 2024
62a8aa4
Fix
mtojek Jan 31, 2024
0ed38ed
Fix?
mtojek Jan 31, 2024
5b4d9a5
StatusForbidden
mtojek Jan 31, 2024
f2ccc2b
Fix?
mtojek Jan 31, 2024
0ae057f
Fix?
mtojek Jan 31, 2024
99c9ad7
Fix?
mtojek Jan 31, 2024
775ee34
Fix?
mtojek Jan 31, 2024
967cdde
fmt
mtojek Feb 1, 2024
d5ecf16
WIP
mtojek Feb 1, 2024
9c6a496
Use third-party renderer
mtojek Feb 1, 2024
f139191
Renderer works
mtojek Feb 1, 2024
cb3796f
fmt
mtojek Feb 1, 2024
687eb89
xss
mtojek Feb 1, 2024
de24c0b
comment
mtojek Feb 1, 2024
6264530
make gen
mtojek Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@mtojek
mtojek committed Jan 31, 2024
commit 62a8aa4bf2f8ec502628eef33b8c496337f331ee
6 changes: 3 additions & 3 deletions coderd/userauth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,9 +1315,9 @@ func (api *API) oauthLogin(r *http.Request, params *oauthLoginParams) ([]*http.C
}

if user.ID == uuid.Nil && !params.AllowSignups {
signupsDisabledText := api.OIDCConfig.SignupsDisabledText
if signupsDisabledText == "" {
signupsDisabledText = "Please contact your Coder administrator to request access."
signupsDisabledText := "Please contact your Coder administrator to request access."
if api.OIDCConfig != nil && api.OIDCConfig.SignupsDisabledText != "" {
signupsDisabledText = api.OIDCConfig.SignupsDisabledText
}
return httpError{
code: http.StatusBadRequest,
Expand Down