fix: strip timezone information from a date in dau response #11962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timezone information is lost, so do not forward it to the client.
Emyrk
commented
Jan 31, 2024
Comment on lines
-2187
to
2205
| func TimezoneOffsetHour(loc *time.Location) int { | ||
| // TimezoneOffsetHourWithTime is implemented to match the javascript 'getTimezoneOffset()' function. | ||
| // This is the amount of time between this date evaluated in UTC and evaluated in the 'loc' | ||
| // The trivial case of times being on the same day is: | ||
| // 'time.Now().UTC().Hour() - time.Now().In(loc).Hour()' | ||
| func TimezoneOffsetHourWithTime(now time.Time, loc *time.Location) int { | ||
| if loc == nil { | ||
| // Default to UTC time to be consistent across all callers. | ||
| loc = time.UTC | ||
| } | ||
| _, offsetSec := time.Now().In(loc).Zone() | ||
| // Convert to hours | ||
| return offsetSec / 60 / 60 | ||
| _, offsetSec := now.In(loc).Zone() | ||
| // Convert to hours and flip the sign | ||
| return -1 * offsetSec / 60 / 60 | ||
| } | ||
|
|
||
| func TimezoneOffsetHour(loc *time.Location) int { | ||
| return TimezoneOffsetHourWithTime(time.Now(), loc) | ||
| } |
There was a problem hiding this comment.
This value was flipped from the javascript implementation. Given this value comes from the browser, I made it match the javascript. I fixed all the tests to be deterministic so we can keep them on.
There was a problem hiding this comment.
I also verified this is the same on Postgres
johnstcn
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timezone information is lost, so do not forward it to the client.
See issue for debugging details
Closes #11943