Skip to content

fix(flake.nix): add google-chrome to nix flake #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix(flake.nix): add google-chrome to nix flake #11974

merged 1 commit into from
Feb 2, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 1, 2024 •
edited
Loading

Required for scaletest tests.

@johnstcn johnstcn self-assigned this Feb 1, 2024
@johnstcn johnstcn changed the title fix(dogfood/flake.nix): add google-chrome fix(flake.nix): add google-chrome to nix flake Feb 1, 2024
@johnstcn johnstcn requested review from mafredri and mtojek February 1, 2024 10:11
@matifali
Copy link
Member

matifali commented Feb 1, 2024 •
edited
Loading

I am not a nix expert but why do we need this? I think we install the headless browsers Here

coder/site/package.json

Line 18 in 510d936

"playwright:install": "playwright install --with-deps chromium",

@matifali
Copy link
Member

matifali commented Feb 1, 2024

Another option can be to install google-chrome in final Ubuntu stage.

mtojek
mtojek approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atif, most likely it is used by one of the scaletests .sh scripts

@matifali
Copy link
Member

matifali commented Feb 1, 2024

Ok. But does it matter if the google-chrome is in Nix stage or the final Ubuntu stage of the Docker build?
It will be always on path for both cases.

@johnstcn
Copy link
Member Author

johnstcn commented Feb 1, 2024

Ok. But does it matter if the google-chrome is in Nix stage or the final Ubuntu stage of the Docker build? It will be always on path for both cases.

No, it just needs to be in $PATH. If it's more efficient to install in the final stage, we can do that instead.

@johnstcn johnstcn merged commit 6593de3 into main Feb 2, 2024
@johnstcn johnstcn deleted the cj/nix-chrome branch February 2, 2024 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @matifali @mtojek