Skip to content

feat(site): allow any file extension on template editor #12000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 7, 2024
Merged

feat(site): allow any file extension on template editor #12000

merged 20 commits into from
Feb 7, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Feb 2, 2024 •
edited
Loading

  • Accepts any file extension on the template editor
  • Keep the version updated in the URL so the page does not lose state
  • Keep the active file in the URL so it is "shareable" and does not lose state on refresh
Screen.Recording.2024-02-02.at.14.04.02.mov
Screen.Recording.2024-02-05.at.14.30.15.mov

@matifali I really would appreciate a rough QA on this 🙏

@BrunoQuaresma BrunoQuaresma self-assigned this Feb 2, 2024
@BrunoQuaresma
Copy link
Collaborator Author

I still need to refactor the TemplateFilesPage.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2024 •
edited
Loading

✔️ PR 12000 Updated successfully.
🚀 Access the credentials here.

cc: @BrunoQuaresma

@BrunoQuaresma BrunoQuaresma changed the title WIP: feat(site): allow any file extension on template editor feat(site): allow any file extension on template editor Feb 6, 2024
@BrunoQuaresma BrunoQuaresma requested review from a team and aslilac and removed request for a team February 6, 2024 11:18
mtojek
mtojek reviewed Feb 6, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts based on videos you posted:

  1. Could we join directories without files? For example, usr/share/keyrings instead of:
Screenshot 2024-02-06 at 16 09 41

Definitely, less clicking.

  1. Can you try with relatively long names and deep, deep directories?

  2. Can we grey out hidden files, so ones starting with a dot?

@BrunoQuaresma
Copy link
Collaborator Author

  1. I like the idea! Let me see if I can extend this component to support this.
  2. This is going to generate horizontal scrolling like happens with VSCode and any IDE editor. Thoughts?
  3. If by "hidden files" you mean folders or files that start with a dot, we can do it easily.

@mtojek
Copy link
Member

mtojek commented Feb 7, 2024

This is going to generate horizontal scrolling like happens with VSCode and any IDE editor. Thoughts?

It might be inevitable in this case, not sure if there is a better way to show it in UI :)

mtojek
mtojek approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback!

@BrunoQuaresma BrunoQuaresma merged commit 4b1bac3 into main Feb 7, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/template-editor branch February 7, 2024 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@mtojek mtojek mtojek approved these changes

@aslilac aslilac Awaiting requested review from aslilac aslilac was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @mtojek @matifali