Skip to content

feat: show workspace name suggestions below the name field #12001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2024
Merged

feat: show workspace name suggestions below the name field #12001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e6e1cd
feat: show workspace name suggestions below the name field
aslilac Feb 2, 2024
05f011f
🧹
aslilac Feb 2, 2024
18d1b2f
exclude random name from chromatic snapshot
aslilac Feb 2, 2024
46d5874
tests and stories
aslilac Feb 2, 2024
b8de785
🧪
aslilac Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests and stories
  • Loading branch information
@aslilac
aslilac committed Feb 2, 2024
commit 46d5874da57b24468591795c98e41770fa635e68
2 changes: 1 addition & 1 deletion site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ describe("CreateWorkspacePage", () => {
it("Detects when a workspace is being created with the 'duplicate' mode", async () => {
const params = new URLSearchParams({
mode: "duplicate",
name: MockWorkspace.name,
name: `${MockWorkspace.name}-copy`,
version: MockWorkspace.template_active_version_id,
});

Expand Down
12 changes: 12 additions & 0 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,18 @@ export const CreateWorkspaceError: Story = {
},
};

export const SpecificVersion: Story = {
args: {
versionId: "specific-version",
},
};

export const Duplicate: Story = {
args: {
mode: "duplicate",
},
};

export const Parameters: Story = {
args: {
parameters: [
Expand Down