feat: add watchdog to pubsub #12011
Merged
feat: add watchdog to pubsub #12011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
5d02e30 to
d4cc468
Compare
d4cc468 to
4624bf1
Compare
mtojek
approved these changes
Feb 6, 2024
|
|
||
| func (w *Watchdog) subscribeMonitor() { | ||
| defer w.wg.Done() | ||
| beats := make(chan struct{}) |
There was a problem hiding this comment.
It is unbuffered, should we make it non-blocking in case of any perf issues?
There was a problem hiding this comment.
PGPubsub buffers events in a ring-buffer, another buffer would be redundant.
4624bf1 to
31c5c83
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a watchdog to our pubsub and runs it for Coder server.
If the watchdog times out, it triggers a graceful exit in
coder serverto give any provisioner jobs a chance to shut down.c.f. #11950