Skip to content

chore: add logs to pq notification dialer #12020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

deansheather
Copy link
Member

Adds TCP connection start, fail and connection success logging to pq pubsub. May help diagnose some issues

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple suggestions inline, but I don't need to review again.

@deansheather deansheather enabled auto-merge (squash) February 6, 2024 11:19
@deansheather deansheather merged commit 98b86f3 into main Feb 6, 2024
@deansheather deansheather deleted the dean/pq-listen-dial-logs branch February 6, 2024 15:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants