Skip to content

feat: add support for optional external auth providers #12021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Feb 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
f9feb97
frontend hacking
aslilac Feb 9, 2024
179adae
pipe through all of the protobuf stuff
aslilac Feb 9, 2024
bdf6142
db migration
aslilac Feb 9, 2024
751400b
💅
aslilac Feb 12, 2024
5068d88
Merge branch 'main' into optional-external-auth
aslilac Feb 12, 2024
eaddb5b
🧹
aslilac Feb 12, 2024
eba3d12
tests!
aslilac Feb 12, 2024
ebb518b
🧪
aslilac Feb 12, 2024
29be417
official release
aslilac Feb 12, 2024
48267a4
add default first in up migration
aslilac Feb 12, 2024
e870667
manually default
aslilac Feb 12, 2024
d58c088
connect with correct version
aslilac Feb 13, 2024
757ea0f
Merge branch 'main' into optional-external-auth
aslilac Feb 14, 2024
79ad9da
land the backend changes separately
aslilac Feb 14, 2024
6746f88
fix migration order
aslilac Feb 14, 2024
cb7ab9a
version.go is not generated
aslilac Feb 14, 2024
3bacc70
it could just all go away
aslilac Feb 15, 2024
28a878d
Revert "it could just all go away"
aslilac Feb 15, 2024
b514292
Merge branch 'main' into optional-external-auth
aslilac Feb 15, 2024
892a79b
change tested version
aslilac Feb 15, 2024
c5e63eb
add `database.ExternalAuthProviders` type
aslilac Feb 15, 2024
6f933b8
Merge branch 'main' into optional-external-auth
aslilac Feb 16, 2024
ea81a1f
`drop` migration functions
aslilac Feb 16, 2024
2376357
`make gen`
aslilac Feb 16, 2024
b9471a5
Merge branch 'main' into optional-external-auth
aslilac Feb 16, 2024
b2b9e95
🆘
aslilac Feb 16, 2024
b159156
Merge branch 'main' into optional-external-auth
aslilac Feb 20, 2024
04579de
no such file
aslilac Feb 20, 2024
7ff56b1
bump version again
aslilac Feb 20, 2024
16ba268
update test
aslilac Feb 20, 2024
bdb875a
Merge branch 'main' into optional-external-auth
aslilac Feb 21, 2024
328202a
fix migration numbers
aslilac Feb 21, 2024
a475ec0
Merge branch 'main' into optional-external-auth
aslilac Feb 21, 2024
353e6a3
`COMMENT ON VIEW`
aslilac Feb 21, 2024
1021bc4
`make gen`
aslilac Feb 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test
  • Loading branch information
aslilac committed Feb 20, 2024
commit 16ba268e482e6e044ea5dcf6449a0529444c76bd
2 changes: 1 addition & 1 deletion enterprise/coderd/provisionerdaemons_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ func TestProvisionerDaemonServe(t *testing.T) {
b, err := io.ReadAll(resp.Body)
require.NoError(t, err)
// The below means that provisionerd tried to serve us, checked our api version, and said nope.
require.Contains(t, string(b), "server is at version 1.0, behind requested major version 2.1")
require.Contains(t, string(b), fmt.Sprintf("server is at version %s, behind requested major version %s", proto.CurrentVersion.String(), v.String()))
})

t.Run("NoLicense", func(t *testing.T) {
Expand Down