feat: Generate random admin user password in dev mode #1207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 66.25% 66.09% -0.16%
==========================================
Files 265 265
Lines 16681 16771 +90
Branches 157 157
==========================================
+ Hits 11052 11085 +33
- Misses 4484 4527 +43
- Partials 1145 1159 +14
Continue to review full report at Codecov.
|
johnstcn
reviewed
Apr 28, 2022
cli/server_test.go
Outdated
|
|
||
| wantEmail := "myadmin@coder.com" | ||
| wantPassword := "testpass42" | ||
| os.Setenv("CODER_DEV_ADMIN_EMAIL", wantEmail) |
There was a problem hiding this comment.
t.Setenv handles this for you :-)
johnstcn
reviewed
Apr 28, 2022
cli/server_test.go
Outdated
| root.SetOutput(&stdoutBuf) | ||
| var buf strings.Builder | ||
| root.SetOutput(&buf) | ||
| done := make(chan struct{}) |
There was a problem hiding this comment.
minor: another way to do this is to use sync.WaitGroup:
var wg sync.WaitGroup
go myFunc() {
... stuff happens
wg.Done()
}()
wg.Add(1)
wg.Wait()
coadler
approved these changes
Apr 28, 2022
presleyp
approved these changes
Apr 28, 2022
greyscaled
approved these changes
Apr 28, 2022
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* feat: Generate random admin user password in dev mode * Add dev mode test with email/pass from env * Set email/pass for playwright e2e test via cli flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the static dev mode admin password with a randomly generated one. It allows both email and password to be set either via environment or command line flags.
Normally passwords as cli flags is suboptimal, but considering the use case I think it's acceptable and may be nicer for the developer.
This PR also fixes a flake in the TestServer/Development test.
Closes #825