Skip to content

feat: handle log limit exceeded in logSender #12079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2024
Merged

feat: handle log limit exceeded in logSender #12079

merged 1 commit into from
Feb 9, 2024

Conversation

spikecurtis
Copy link
Contributor

@spikecurtis spikecurtis commented Feb 9, 2024 •
edited
Loading

Modify the logSender to gracefully handle the log limit being exceeded on the server side.

Here we just drop a warning in the Coder agent log and then silently discard all new logs, since the server won't accept them.

This was referenced Feb 9, 2024
Merged
Merged
Merged
Merged
@spikecurtis Graphite App
Copy link
Contributor Author

spikecurtis commented Feb 9, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikecurtis and the rest of your teammates on Graphite Graphite

@spikecurtis spikecurtis mentioned this pull request Feb 9, 2024
Merged
@spikecurtis spikecurtis requested a review from mafredri February 9, 2024 11:59
@spikecurtis spikecurtis marked this pull request as ready for review February 9, 2024 11:59
@spikecurtis spikecurtis force-pushed the spike/10534-log-sender branch from 15855f4 to 3047485 Compare February 9, 2024 12:05
@spikecurtis spikecurtis force-pushed the spike/10534-log-sender-handle-log-limit-exceeded branch from 89ce3e7 to c8e7282 Compare February 9, 2024 12:05
@spikecurtis spikecurtis force-pushed the spike/10534-log-sender branch from 3047485 to ad9d94a Compare February 9, 2024 12:53
@spikecurtis spikecurtis force-pushed the spike/10534-log-sender-handle-log-limit-exceeded branch from c8e7282 to 0515169 Compare February 9, 2024 12:53
@spikecurtis spikecurtis merged commit 0515169 into spike/10534-log-sender Feb 9, 2024
@spikecurtis spikecurtis deleted the spike/10534-log-sender-handle-log-limit-exceeded branch February 9, 2024 12:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spikecurtis