Skip to content

chore(examples): add sample Incus template #12114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2024
Merged

chore(examples): add sample Incus template #12114

merged 2 commits into from
Feb 13, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 13, 2024 •
edited
Loading

This template was created mainly for FOSDEM, but I found getting it Right an involved enough process that I'd prefer to not lose the work.

@johnstcn johnstcn requested review from matifali and mtojek February 13, 2024 13:35
@johnstcn johnstcn self-assigned this Feb 13, 2024
mtojek
mtojek approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you add a short description to the PR about the motivation behind this change? Is it for your personal use?

@johnstcn
Copy link
Member Author

LGTM

Could you add a short description to the PR about the motivation behind this change? Is it for your personal use?

I don't anticipate using it personally, but I just don't want the hours I spent getting it working to be for naught ;-)

@johnstcn johnstcn merged commit c939416 into main Feb 13, 2024
@johnstcn johnstcn deleted the cj/example-incus branch February 13, 2024 14:30
matifali
matifali reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my testing incus creates two groups incus and incus-admin.

And the unix socket is owned by root:incus-admin.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali left review comments

@mtojek mtojek mtojek approved these changes

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnstcn @matifali @mtojek