fix: fix pgcoord to delete coordinator row last #12155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spikecurtis and the rest of your teammates on |
mafredri
approved these changes
Feb 15, 2024
| @@ -454,6 +474,9 @@ func newBinder(ctx context.Context, | |||
| workQ: newWorkQ[bKey](ctx), | |||
| } | |||
| go b.handleBindings() | |||
| // add to the waitgroup immediately to avoid any races waiting for it before | |||
| // the workers start. | |||
| b.workerWG.Add(numBinderWorkers) | |||
There was a problem hiding this comment.
Is there a chance that <-startWorkers below (i.e. fHB) doesn't get closed (e.g. some error during startup), and thus, these waitgroups never resolving?
(I didn't try to dig in as to how or where fHB is closed as it's not obvious from this PR.)
There was a problem hiding this comment.
It gets closed unconditionally after we send the first heartbeat (success or fail).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12141
Fixes #11750
PGCoord shutdown was uncoordinated, so an update at an inopportune time during shutdown would be rejected because the coordinator row was already deleted.
This PR ensures that the PGCoord subcomponents that write updates are shut down before we take down the heartbeats, which is responsible for deleting the coordinator row.