Skip to content

chore: deprecate API workspace build resources #12167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 15, 2024
Merged

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 15, 2024

While working on #8995, I noticed that this endpoint is not used by the frontend or CLI, so let's park it for removal in the future.

@mtojek mtojek self-assigned this Feb 15, 2024
@mtojek mtojek changed the title chore: deprecate workspace build resources chore: deprecate API workspace build resources Feb 15, 2024
@mtojek mtojek requested a review from johnstcn February 15, 2024 14:52
@mtojek mtojek marked this pull request as ready for review February 15, 2024 14:52
// @Tags Builds
// @Param workspacebuild path string true "Workspace build ID"
// @Success 200 {array} codersdk.WorkspaceResource
// @Router /workspacebuilds/{workspacebuild}/resources [get]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// @Router /workspacebuilds/{workspacebuild}/resources [get]
// @Router /workspacebuilds/{workspacebuild}/resources [get]
// @Deprecated this endpoint is unused and will be removed in future

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@mtojek mtojek merged commit 5aa5ff1 into main Feb 15, 2024
@mtojek mtojek deleted the deprecate-resources branch February 15, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants