Skip to content

feat: Update Terraform provider to support "dir" in "coder_agent" #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2022
Merged

feat: Update Terraform provider to support "dir" in "coder_agent" #1219

merged 3 commits into from
May 2, 2022

Conversation

kylecarbs
Copy link
Member

This allows users to specify a starting directory for shell sessions.

@kylecarbs kylecarbs requested review from coadler and bpmct April 29, 2022 15:22
@kylecarbs kylecarbs self-assigned this Apr 29, 2022
@codecov
Copy link

codecov bot commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #1219 (0e7988e) into main (b948f2d) will increase coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
+ Coverage   65.87%   65.90%   +0.02%     
==========================================
  Files         272      272              
  Lines       17886    17917      +31     
  Branches      192      192              
==========================================
+ Hits        11783    11808      +25     
- Misses       4877     4881       +4     
- Partials     1226     1228       +2
Flag Coverage Δ
unittest-go-macos-latest 53.19% <40.00%> (-0.16%) ⬇️
unittest-go-postgres- 64.85% <80.00%> (+0.04%) ⬆️
unittest-go-ubuntu-latest 55.61% <56.00%> (+<0.01%) ⬆️
unittest-go-windows-2022 51.55% <40.00%> (-1.26%) ⬇️
unittest-js 69.96% <ø> (ø)
Impacted Files Coverage Δ
codersdk/workspaceresources.go 45.45% <ø> (ø)
provisioner/terraform/provision.go 70.46% <44.44%> (-0.94%) ⬇️
agent/agent.go 65.36% <100.00%> (-0.27%) ⬇️
coderd/database/queries.sql.go 81.14% <100.00%> (+0.07%) ⬆️
coderd/provisionerdaemons.go 63.48% <100.00%> (+0.18%) ⬆️
coderd/workspaceagents.go 58.83% <100.00%> (+2.06%) ⬆️
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
pty/pty_windows.go 70.14% <0.00%> (-4.48%) ⬇️
peer/channel.go 84.39% <0.00%> (-2.32%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b948f2d...0e7988e. Read the comment docs.

@kylecarbs kylecarbs requested a review from a team as a code owner April 29, 2022 15:30
@kylecarbs
feat: Update Terraform provider to support "dir" in "coder_agent"
24f99e6 
This allows users to specify a starting directory for shell sessions.
greyscaled
greyscaled reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ FE is just generated types, LGTM!

@kylecarbs kylecarbs requested a review from code-asher April 30, 2022 21:19
code-asher
code-asher reviewed May 1, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add Directory to InsertWorkspaceAgentParams? Or does Directory get set on the row somewhere else?

@kylecarbs
Copy link
Member Author

@code-asher good catch!

@kylecarbs
Copy link
Member Author

@code-asher I'm going to add a test to ensure the directory gets set.

@kylecarbs
Copy link
Member Author

@code-asher fixed!

@kylecarbs kylecarbs merged commit 8701e00 into main May 2, 2022
@kylecarbs kylecarbs deleted the updatetf branch May 2, 2022 15:27
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
feat: Update Terraform provider to support "dir" in "coder_agent" (#1219
bfcf6f4 
)

This allows users to specify a starting directory for shell sessions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greyscaled greyscaled greyscaled left review comments

@code-asher code-asher code-asher left review comments

@coadler coadler coadler approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kylecarbs @coadler @greyscaled @code-asher