feat: add oauth2 token exchange #12196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
commented
Feb 16, 2024
Emyrk
approved these changes
Feb 20, 2024
Comment on lines
+1236
to
+1240
| // The user ID is on the API key so that has to be fetched. | ||
| key, err := q.db.GetAPIKeyByID(ctx, token.APIKeyID) | ||
| if err != nil { | ||
| return database.OAuth2ProviderAppToken{}, err | ||
| } |
Might have no match, and a -1 will panic.
This will be used as an ID that we can prefix into the secrets themselves. This is so we can salt the hashed secrets. The token query is for implementing the refresh flow.
0204adb to
70cedd6
Compare
7fd123e to
da447c2
Compare
Without this I think the tests would fail since they are not adding a prefix and there is no default.
da447c2 to
e517d8e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened since the original got closed by stale bot and will not let me re-open after force-pushing!
Rename token hashed_secret to refresh_hashand later are new since that PR was last reviewed. The main thing is that a secret prefix was added.#11778