Skip to content

feat(agent): add script data dir for binaries and files #12205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 20, 2024
Merged

feat(agent): add script data dir for binaries and files #12205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebab733
feat(agent): add script data dir for binaries and files
mafredri Feb 19, 2024
61007e8
add agentscript test
mafredri Feb 19, 2024
7f438cc
handle window paths
mafredri Feb 19, 2024
c30a1c3
fix path test
mafredri Feb 19, 2024
e4053c8
cleanup datadir
mafredri Feb 19, 2024
35968dd
always log
mafredri Feb 19, 2024
0f6f254
add log dir log for good measure
mafredri Feb 19, 2024
fddefbd
update golden files
mafredri Feb 19, 2024
58ee327
try to fix test on Win
mafredri Feb 19, 2024
7dbfc2b
Apply suggestions from code review
mafredri Feb 19, 2024
3234143
execute async to ensure log processing
mafredri Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@mafredri
mafredri committed Feb 20, 2024
commit 7dbfc2b997102a6813f4e3f834a43af44646f7df
2 changes: 0 additions & 2 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,9 +300,7 @@ func TestAgent_Session_EnvironmentVariables(t *testing.T) {
},
}
banner := codersdk.ServiceBannerConfig{}
fs := afero.NewMemMapFs()
session := setupSSHSession(t, manifest, banner, nil, func(_ *agenttest.Client, opts *agent.Options) {
opts.Filesystem = fs
opts.ScriptDataDir = tmpdir
opts.EnvironmentVariables["MY_OVERRIDE"] = "true"
})
Expand Down
2 changes: 1 addition & 1 deletion cli/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ func (r *RootCmd) workspaceAgent() *clibase.Cmd {
Flag: "script-data-dir",
Default: os.TempDir(),
Description: "Specify the location for storing script data.",
Env: "CODER_AGENT_SCRIPT_DIR",
Env: "CODER_AGENT_SCRIPT_DATA_DIR",
Value: clibase.StringOf(&scriptDataDir),
},
{
Expand Down
2 changes: 1 addition & 1 deletion cli/testdata/coder_agent_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ OPTIONS:
--prometheus-address string, $CODER_AGENT_PROMETHEUS_ADDRESS (default: 127.0.0.1:2112)
The bind address to serve Prometheus metrics.

--script-data-dir string, $CODER_AGENT_SCRIPT_DIR (default: /tmp)
--script-data-dir string, $CODER_AGENT_SCRIPT_DATA_DIR (default: /tmp)
Specify the location for storing script data.

--ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 72h)
Expand Down