Skip to content

feat: add OAuth2 user settings page #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2024
Merged

feat: add OAuth2 user settings page #12237

merged 5 commits into from
Feb 21, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Feb 21, 2024

I believe nothing has changed here since the last time this was reviewed except that the authorization page was deleted since it was moved to the backend. Edit: added two new commits.

There is no link to the page yet since it is restricted to dev mode.

@code-asher code-asher changed the title feat: add user settings page for revoking OAuth2 apps feat: add OAuth2 user settings page Feb 21, 2024
This keeps running every time you revoke an application.  I guess the
refresh is happening before the ID is set to undefined?  But I do not
want to unset it earlier because I want the dialog to stay open.  For
now I will just remove this block.
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks really good!

@code-asher code-asher merged commit 51d178d into main Feb 21, 2024
@code-asher code-asher deleted the asher/oauth2-exchange-fe branch February 21, 2024 23:16
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants