Skip to content

feat(site): allow creating a workspace without connecting optional external auth providers #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 22, 2024
Merged

feat(site): allow creating a workspace without connecting optional external auth providers #12251

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ee3bad
changes from base
aslilac Feb 21, 2024
c04cd37
support optional external auth providers in the frontend
aslilac Feb 21, 2024
f00b991
🧹
aslilac Feb 21, 2024
5ba780d
remove unnecessary test
aslilac Feb 21, 2024
b8bed3c
Merge branch 'main' into optional-external-auth-frontend
aslilac Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary test
  • Loading branch information
@aslilac
aslilac committed Feb 21, 2024
commit 5ba780d1d8f79e543de7f5aeae86afcc95d19c11
11 changes: 0 additions & 11 deletions site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,17 +233,6 @@ describe("CreateWorkspacePage", () => {
);
});

it("external auth errors if unauthenticated", async () => {
jest
.spyOn(API, "getTemplateVersionExternalAuth")
.mockResolvedValueOnce([MockTemplateVersionExternalAuthGithub]);

renderCreateWorkspacePage();
await waitForLoaderToBeRemoved();

await screen.findByText(/connect to all required/i);
});

it("auto create a workspace if uses mode=auto", async () => {
const param = "first_parameter";
const paramValue = "It works!";
Expand Down