Skip to content

feat(site): display build logs on template creation #12271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Feb 23, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Kayla Washburn-Love <mckayla@hey.com>
  • Loading branch information
BrunoQuaresma and aslilac authored Feb 23, 2024
commit 485ae40894cebcce5962a904dc8ad307c816cbbc
2 changes: 1 addition & 1 deletion site/src/api/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1575,7 +1575,7 @@ export const watchBuildLogsByTemplateVersionId = (
});
socket.addEventListener("close", () => {
// When the socket closes, logs have finished streaming!
onDone && onDone();
onDone?.();
});
return socket;
};
Expand Down