feat: audit oauth2 app management #12275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3566955 to
1b6b495
Compare
1b6b495 to
ed2ac9e
Compare
Emyrk
approved these changes
Feb 26, 2024
codersdk/audit.go
Outdated
Comment on lines
65
to
69
| case ResourceTypeOAuth2ProviderApp: | ||
| return "OAuth2 app" | ||
| case ResourceTypeOAuth2ProviderAppSecret: | ||
| // OAuth2 secrets have a unique friendly string. | ||
| return "OAuth2 app secret" |
There was a problem hiding this comment.
The other ones are lowercase. Should this be too? Genuine question
There was a problem hiding this comment.
This is what shows up in the audit log entry, so we get admin created OAuth2 app, and I figured I should capitalize it properly with it being a full sentence and all but honestly I am not sure what the user expectation here is!
There was a problem hiding this comment.
Part of me wants to lowercase just because I like the lowercase though.
And remove an old comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds audit log entries for creating/editing/deleting apps and secrets.