refactor(coderd): move healthcheck report structs to codersdk #12279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e7faa6 to
e6b7428
Compare
e6b7428 to
621fa13
Compare
mtojek
reviewed
Feb 23, 2024
Unfortunately, yes. Most of the changes are in generated files. |
mtojek
approved these changes
Feb 23, 2024
|
Also smoke-tested that:
|
BrunoQuaresma
approved these changes
Feb 23, 2024
mafredri
approved these changes
Feb 23, 2024
| "tailscale.com/net/netcheck" | ||
| "tailscale.com/tailcfg" | ||
|
|
||
| "github.com/coder/coder/v2/coderd/healthcheck/health" |
There was a problem hiding this comment.
I wonder if this also should be a part of codersdk. 🤔
There was a problem hiding this comment.
Yeah, I started doing that but then started to realize how big this PR would be 😅
I can open a new PR for this, but it's not a real blocker for now.
johnstcn
commented
Feb 23, 2024
Comment on lines
+31
to
+37
| baseDirs = [...]string{"./codersdk"} | ||
| // externalTypes are types that are not in the baseDirs, but we want to | ||
| // support. These are usually types that are used in the baseDirs. | ||
| // Do not include things like "Database", as that would break the idea | ||
| // of splitting db and api types. | ||
| // Only include dirs that are client facing packages. | ||
| externalTypeDirs = [...]string{"./cli/clibase", "./coderd/healthcheck/health", "./coderd/healthcheck/derphealth"} | ||
| externalTypeDirs = [...]string{"./cli/clibase", "./coderd/healthcheck/health"} |
There was a problem hiding this comment.
review: no longer need to generate coderd/healthcheck and coderd/healthcheck/derphealth.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by #12161 to avoid an import cycle when adding a
codersdk.Clientmethod to hit/api/v2/debug/health.Moves healthcheck report-related structs from
coderd/healthchecktocodersdk