Skip to content

chore: Port ConfirmDialog from v1 #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 29, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 29, 2022 19:33
@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1228 (4bff20c) into main (69e26c4) will increase coverage by 0.10%.
The diff coverage is 83.75%.

@@            Coverage Diff             @@
##             main    #1228      +/-   ##
==========================================
+ Coverage   65.65%   65.76%   +0.10%     
==========================================
  Files         269      272       +3     
  Lines       17365    17446      +81     
  Branches      162      186      +24     
==========================================
+ Hits        11401    11473      +72     
- Misses       4771     4778       +7     
- Partials     1193     1195       +2     
Flag Coverage Δ
unittest-go-macos-latest 53.05% <ø> (+0.07%) ⬆️
unittest-go-postgres- 64.77% <ø> (-0.04%) ⬇️
unittest-go-ubuntu-latest 55.46% <ø> (+0.09%) ⬆️
unittest-go-windows-2022 52.58% <ø> (+0.08%) ⬆️
unittest-js 69.63% <83.75%> (+0.77%) ⬆️
Impacted Files Coverage Δ
site/src/theme/palettes.ts 100.00% <ø> (ø)
site/src/components/Dialog/Dialog.tsx 74.41% <74.41%> (ø)
...ite/src/components/ConfirmDialog/ConfirmDialog.tsx 94.11% <94.11%> (ø)
site/src/components/Icons/SearchIcon.tsx 100.00% <100.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
site/src/pages/UsersPage/UsersPage.tsx 75.00% <0.00%> (-7.36%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
site/src/xServices/users/usersXService.ts 80.00% <0.00%> (-1.25%) ⬇️
peer/conn.go 77.91% <0.00%> (-0.50%) ⬇️
site/src/api/index.ts 65.30% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e26c4...4bff20c. Read the comment docs.

@BrunoQuaresma BrunoQuaresma merged commit 2043d1a into main May 2, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-dialog-and-confirm-dialog branch May 2, 2022 13:17
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants