chore: enforce orgid in audit logs where required #12283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Feb 23, 2024
Comment on lines
+210
to
+214
| // In unit tests we panic to fail the tests | ||
| panic(fmt.Sprintf("missing required organization ID for resource %q", resourceName)) | ||
| } | ||
| log.Error(ctx, "missing required organization ID for resource in audit log", | ||
| slog.F("resource", resourceName), |
There was a problem hiding this comment.
maybe no harm to also include resource type?
Edit: %T does that, the varname resourceName threw me off
maybe we can do %+v in unit tests? or would that be too much?
There was a problem hiding this comment.
I think %+v is too much and we'd have to be careful with any secrets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Populates and requires the
organizationIDfield to audit logs where it can be set.Some resources are not scoped to an org. This is ok imo, but from a UI perspective, we might have org vs site audit log views in the future.
Closes #11930