Skip to content

fix: clarify AWS access key ID vs secret #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

fix: clarify AWS access key ID vs secret #1231

merged 1 commit into from
May 2, 2022

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Apr 29, 2022

This is how AWS differentiates access key vs secret

@bpmct bpmct requested a review from presleyp April 29, 2022 19:42
@codecov
Copy link

codecov bot commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #1231 (2780429) into main (021e4cd) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
+ Coverage   65.65%   65.68%   +0.02%     
==========================================
  Files         269      269              
  Lines       17366    17366              
  Branches      164      164              
==========================================
+ Hits        11402    11407       +5     
+ Misses       4772     4770       -2     
+ Partials     1192     1189       -3
Flag Coverage Δ
unittest-go-macos-latest 52.95% <ø> (-0.05%) ⬇️
unittest-go-postgres- 64.73% <ø> (-0.06%) ⬇️
unittest-go-ubuntu-latest 55.42% <ø> (+0.03%) ⬆️
unittest-go-windows-2022 52.60% <ø> (+0.08%) ⬆️
unittest-js 68.87% <ø> (ø)
Impacted Files Coverage Δ
coderd/workspaceagents.go 55.59% <0.00%> (-2.56%) ⬇️
cli/cliui/provisionerjob.go 76.42% <0.00%> (-2.15%) ⬇️
peer/channel.go 83.81% <0.00%> (-1.16%) ⬇️
peerbroker/proxy.go 58.13% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 62.28% <0.00%> (-0.51%) ⬇️
provisionerd/provisionerd.go 76.30% <0.00%> (+0.13%) ⬆️
provisioner/terraform/provision.go 71.39% <0.00%> (+0.43%) ⬆️
peer/conn.go 78.16% <0.00%> (+1.48%) ⬆️
peerbroker/listen.go 87.39% <0.00%> (+3.36%) ⬆️
provisioner/echo/serve.go 59.20% <0.00%> (+4.80%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021e4cd...2780429. Read the comment docs.

presleyp
presleyp approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kylecarbs kylecarbs mentioned this pull request Apr 29, 2022
Merged
@bpmct bpmct merged commit aaf6aee into main May 2, 2022
@bpmct bpmct deleted the bpmct/aws-clarify branch May 2, 2022 15:28
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@bpmct @kylecarbs
fix: clarify AWS access key ID vs secret (#1231)
7ebc468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@bpmct @presleyp @misskniss