Skip to content

fix: use flag to enable Prometheus #12345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 28, 2024
Merged

fix: use flag to enable Prometheus #12345

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
88ad685
fix: add flag to enable Prometheus
mtojek Feb 28, 2024
37fba4e
md
mtojek Feb 28, 2024
78a4b76
test
mtojek Feb 28, 2024
d6b6c9f
golden
mtojek Feb 28, 2024
ef44bdd
fix
mtojek Feb 28, 2024
b91b549
unit test for wsproxy
mtojek Feb 28, 2024
e9d5175
fix port
mtojek Feb 28, 2024
e0e5c4c
docs
mtojek Feb 28, 2024
5e168eb
assertCallback
mtojek Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: add flag to enable Prometheus
  • Loading branch information
@mtojek
mtojek committed Feb 28, 2024
commit 88ad6857474f3e0d3c993f712afe31c0aad8b71e
10 changes: 9 additions & 1 deletion enterprise/cli/provisionerdaemons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ func (r *RootCmd) provisionerDaemonStart() *clibase.Cmd {
preSharedKey string
verbose bool

prometheusEnable bool
prometheusAddress string
)
client := new(codersdk.Client)
Expand Down Expand Up @@ -171,7 +172,7 @@ func (r *RootCmd) provisionerDaemonStart() *clibase.Cmd {
}()

var metrics *provisionerd.Metrics
if prometheusAddress != "" {
if prometheusEnable {
logger.Info(ctx, "starting Prometheus endpoint", slog.F("address", prometheusAddress))

prometheusRegistry := prometheus.NewRegistry()
Expand Down Expand Up @@ -315,6 +316,13 @@ func (r *RootCmd) provisionerDaemonStart() *clibase.Cmd {
Value: clibase.StringArrayOf(&logFilter),
Default: "",
},
{
Flag: "prometheus-enable",
Env: "CODER_PROMETHEUS_ENABLE",
Description: "Serve prometheus metrics on the address defined by prometheus address.",
Value: clibase.BoolOf(&prometheusEnable),
Default: "false",
},
{
Flag: "prometheus-address",
Env: "CODER_PROMETHEUS_ADDRESS",
Expand Down