Skip to content

chore: update provisioner tag documentation with suggestions from #12315 #12347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn requested a review from spikecurtis February 28, 2024 13:26
@johnstcn johnstcn self-assigned this Feb 28, 2024
@johnstcn johnstcn marked this pull request as ready for review February 28, 2024 13:26
@johnstcn johnstcn changed the title chore(docs): update provisioner tag documentation with suggestions from #12315 chore: update provisioner tag documentation with suggestions from #12315 Feb 28, 2024
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the use of the test case to generate the example table.

Some more suggestions inline, but I don't need to review again.

@johnstcn johnstcn enabled auto-merge (squash) February 29, 2024 12:25
@johnstcn johnstcn merged commit 4f87ba4 into main Feb 29, 2024
@johnstcn johnstcn deleted the cj/provisioner-docs-update branch February 29, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants