chore: add organization_id column to provisioner daemons #12356
Conversation
db381a4 to
c11cfbc
Compare
| organization_id = (SELECT id FROM organizations ORDER BY organizations.created_at ASC LIMIT 1 ); | ||
|
|
||
| ALTER TABLE provisioner_daemons | ||
| ALTER COLUMN organization_id SET NOT NULL; |
There was a problem hiding this comment.
Do we still need to explicitly put this stuff in a transaction? Otherwise a concurrent insert of a provisioner daemon could cause this ALTER to fail.
There was a problem hiding this comment.
No, by default all migrations run in a tx now.
| provisioner_daemons | ||
| SET | ||
| -- Default to the first org | ||
| organization_id = (SELECT id FROM organizations ORDER BY organizations.created_at ASC LIMIT 1 ); |
There was a problem hiding this comment.
it's an odd case, but this will fail if there is a provisioner daemon but no default org, which could happen if you start coderd on an older version (which creates in-memory provisioner daemons) but don't create the first user, and then migrate.
There was a problem hiding this comment.
Yes, we need this PR in first: #12412
| @@ -1239,10 +1239,18 @@ func (api *API) CreateInMemoryProvisionerDaemon(dialCtx context.Context, name st | |||
| } | |||
| }() | |||
|
|
|||
| // All in memory provisioners will be apart of the default org for now. | |||
| //nolint:gocritic // in-memory provisioners are owned by system | |||
| defaultOrg, err := api.Database.GetDefaultOrganization(dbauthz.AsSystemRestricted(dialCtx)) | |||
There was a problem hiding this comment.
I think you've already noticed that this will fail if the default organization hasn't been created. So think we need have a migration that creates a default org if none exists before we can have this.
There was a problem hiding this comment.
Yea, I will make sure this PR is merged first: #12412
Closes #11931