chore: consolidate various randomPort() implementations #12362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Feb 29, 2024
mtojek
approved these changes
Feb 29, 2024
| @@ -838,7 +837,7 @@ func TestAgent_TCPRemoteForwarding(t *testing.T) { | |||
| var ll net.Listener | |||
| var err error | |||
| for { | |||
| randomPort = pickRandomPort() | |||
| randomPort = testutil.RandomPortNoListen(t) | |||
There was a problem hiding this comment.
This one isn't guaranteed to be free and relies on pure randommess.
Regarding the other implementation, I just picked the existing name.
We can rename later if need be. 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates our existing
randomPort()implementations totestutil.RandomPort(NoListen)?.