Skip to content

fix: Update GIT_COMMITTER_NAME to use username #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2022
Merged

fix: Update GIT_COMMITTER_NAME to use username #1237

merged 1 commit into from
Apr 30, 2022

Conversation

kylecarbs
Copy link
Member

This was a mistake when adding the committer fields 🤦.

@kylecarbs
fix: Update GIT_COMMITTER_NAME to use username
81bb820 
This was a mistake when adding the committer fields 🤦.
@kylecarbs kylecarbs requested a review from coadler April 30, 2022 01:37
@kylecarbs kylecarbs self-assigned this Apr 30, 2022
@codecov
Copy link

codecov bot commented Apr 30, 2022 •
edited
Loading

Codecov Report

Merging #1237 (81bb820) into main (2acdd3b) will increase coverage by 10.95%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #1237       +/-   ##
===========================================
+ Coverage   54.84%   65.80%   +10.95%     
===========================================
  Files         266      272        +6     
  Lines       17658    17875      +217     
  Branches      192      192               
===========================================
+ Hits         9685    11763     +2078     
+ Misses       6895     4884     -2011     
- Partials     1078     1228      +150
Flag Coverage Δ
unittest-go-macos-latest 53.24% <100.00%> (-0.05%) ⬇️
unittest-go-postgres- 64.68% <100.00%> (?)
unittest-go-ubuntu-latest 55.61% <100.00%> (?)
unittest-go-windows-2022 52.74% <100.00%> (?)
unittest-js 69.96% <ø> (ø)
Impacted Files Coverage Δ
agent/agent.go 68.35% <100.00%> (+3.16%) ⬆️
codersdk/provisionerdaemons.go 61.97% <0.00%> (-5.64%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
cli/cliui/cliui_other.go 0.00% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
cli/ssh_windows.go 0.00% <0.00%> (ø)
agent/usershell/usershell_other.go 60.00% <0.00%> (ø)
pty/pty_windows.go 74.62% <0.00%> (ø)
provisionerd/provisionerd.go 76.30% <0.00%> (+0.13%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acdd3b...81bb820. Read the comment docs.

@kylecarbs kylecarbs merged commit eb60692 into main Apr 30, 2022
@kylecarbs kylecarbs deleted the fixgit branch April 30, 2022 01:51
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Update GIT_COMMITTER_NAME to use username (#1237)
724332a 
This was a mistake when adding the committer fields 🤦.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler