feat: allow setting port share protocol #12383
Conversation
|
Looks good to me, thanks for plumbing that through, glad it was this simple of a change. I can handle the frontend if you want me to take over this PR from here. |
|
Can we default it to |
|
There is no URL in the request it's just a port, so the separate field is necessary. The frontend will default to HTTP but the API will require it as a field. |
| SELECT | ||
| * | ||
| FROM | ||
| workspace_agent_port_share | ||
| WHERE | ||
| workspace_id = $1 | ||
| AND agent_name = $2 | ||
| AND port = $3; |
There was a problem hiding this comment.
Is there a formatter I should be using but am somehow missing?
There was a problem hiding this comment.
Nope :( I just did it manually
| // list | ||
| list, err := client.GetWorkspaceAgentPortShares(ctx, r.Workspace.ID) | ||
| require.NoError(t, err) | ||
| require.Len(t, list.Shares, 1) | ||
| require.EqualValues(t, agents[0].Name, list.Shares[0].AgentName) | ||
| require.EqualValues(t, 8080, list.Shares[0].Port) | ||
| require.EqualValues(t, codersdk.WorkspaceAgentPortShareLevelPublic, list.Shares[0].ShareLevel) | ||
| require.EqualValues(t, codersdk.WorkspaceAgentPortShareProtocolHTTPS, list.Shares[0].Protocol) |
There was a problem hiding this comment.
thanks for adding this extra coverage
99ed006 to
c925496
Compare
|
@deansheather Please review my additions, and just comment since you can't review your own PR lol. |
Adds
protocolto port shares. Value can either behttporhttps. Previous port shares default tohttp. It's a required field in the API so clients must specify it from now on.Frontend:
