fix(site): retry and debug passing build parameters options #12384
+400
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Mar 1, 2024
|
|
||
| rest.get("/api/v2/integrations/jfrog/xray-scan", (_, res, ctx) => { | ||
| return res(ctx.status(404)); | ||
| }), |
There was a problem hiding this comment.
To avoid getting unhandled request warnings during tests. The warning was introduced many PRs ago but I only noticed it now since it was messing with the output for my tests so I just fixed it.
Kira-Pilot
reviewed
Mar 1, 2024
| @@ -438,4 +438,102 @@ describe("WorkspacePage", () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it("retry with build parameters", async () => { | |||
Kira-Pilot
reviewed
Mar 1, 2024
| ...MockTemplateVersionParameter1, | ||
| display_name: "Parameter 1", | ||
| ephemeral: true, | ||
| } satisfies TemplateVersionParameter; |
There was a problem hiding this comment.
Why do we have to use satisifes here and above?
There was a problem hiding this comment.
When typing the variable directly it was missing a few attribute types after destructuring so using satisfies fixed that.
Kira-Pilot
approved these changes
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #11748