Skip to content

chore: add stories for Popover #12387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024
Merged

chore: add stories for Popover #12387

merged 1 commit into from
Mar 1, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Mar 1, 2024

Part of #11420
Part of #12261

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Had to read up on what the play methods do, and they seem straightforward. Just making sure, though: if a play action fails, that makes the story fail in Chromatic, right?

@aslilac
Copy link
Member Author

aslilac commented Mar 1, 2024

Just making sure, though: if a play action fails, that makes the story fail in Chromatic, right?

Correct. play is the interface for the @storybook/actions testing that I've been so pomp about lately, and Chromatic integrates with it very nicely.

@aslilac aslilac merged commit af4d0b1 into main Mar 1, 2024
@aslilac aslilac deleted the popover-stories branch March 1, 2024 22:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants