feat(site): warn user if they leave the editor without publishing #12406
Conversation
|
I'm not sure if there is a way to test this behavior 😞 but I'm open to learn it in case you know |
|
Unfortunately, Chrome and other browsers do not allow the script to change the warning message. |
There was a problem hiding this comment.
Nice change!
Yeah I thinking testing will be difficult. Maybe Playwright can do it, it has a way to interact with dialogs.
Can we make it work for the back buttons too? The one in the page and the browser back button. I am not entirely sure how though, maybe we have to somehow hook into React navigation?
Some of the tests are failing. It looks like they are trying to click on the build button but it is disabled, so it is probably the addition of && dirty that is breaking them, I guess it is not getting set to true when the tests make their changes.
|
@code-asher 100% I'm going to work on the suggestions. |
|
@code-asher I'm considering not adding e2e tests to this flow since it is a "nice to have" feature. Wdyt? |
Sounds good to me, I am not even sure it would work anyway. 😅 |
Screen.Recording.2024-03-04.at.11.14.14.mov
Close #12360