Skip to content

chore: sort imports in our typescript code #12417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 5, 2024
Merged

chore: sort imports in our typescript code #12417

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9dfdf4b
naive upgrade
aslilac Mar 4, 2024
ea338cc
update config
aslilac Mar 4, 2024
c07b709
🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹🧹
aslilac Mar 4, 2024
a8ed894
tsc
aslilac Mar 4, 2024
79dcc2d
fmt
aslilac Mar 4, 2024
4efd290
fix a bunch of weird things
aslilac Mar 4, 2024
04f8cd6
🧼
aslilac Mar 4, 2024
874ec1a
update some scripts
aslilac Mar 5, 2024
b1b0019
Merge branch 'main' into typescript-import-linting
aslilac Mar 5, 2024
0c02041
🧹
aslilac Mar 5, 2024
288ed0e
🧹
aslilac Mar 5, 2024
3e13fc5
💅
aslilac Mar 5, 2024
e92a7db
🌮
aslilac Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update config
  • Loading branch information
@aslilac
aslilac committed Mar 4, 2024
commit ea338cc956eb371fdea19a5b7749d5ec84d5cd76
10 changes: 10 additions & 0 deletions site/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ root: true
rules:
"@typescript-eslint/brace-style":
["error", "1tbs", { "allowSingleLine": false }]
"@typescript-eslint/consistent-type-imports":
- error
- fixStyle: inline-type-imports
"@typescript-eslint/method-signature-style": ["error", "property"]
# TODO: Investigate whether to enable this rule & fix and/or disable all its complaints
"@typescript-eslint/no-misused-promises": "off"
Expand Down Expand Up @@ -104,6 +107,13 @@ rules:
import/no-named-as-default: "off"
import/no-named-as-default-member: "off"
import/prefer-default-export: "off"
import/order:
- error
- groups: [["builtin", "external"], "internal", "parent"]
newlines-between: never
alphabetize:
order: asc
caseInsensitive: true
jest/no-focused-tests: "error"
jsx-a11y/label-has-for: "off"
jsx-a11y/no-autofocus: "off"
Expand Down
24 changes: 12 additions & 12 deletions site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,23 +130,23 @@
"@types/ssh2": "1.11.13",
"@types/ua-parser-js": "0.7.36",
"@types/uuid": "9.0.2",
"@typescript-eslint/eslint-plugin": "7.1.1",
"@typescript-eslint/parser": "7.1.1",
"@typescript-eslint/eslint-plugin": "6.9.1",
"@typescript-eslint/parser": "6.9.1",
"@vitejs/plugin-react": "4.1.0",
"chromatic": "10.6.1",
"eslint": "8.57.0",
"eslint-config-prettier": "9.1.0",
"eslint-import-resolver-typescript": "3.6.1",
"eslint": "8.52.0",
"eslint-config-prettier": "9.0.0",
"eslint-import-resolver-typescript": "3.6.0",
"eslint-plugin-compat": "4.2.0",
"eslint-plugin-eslint-comments": "3.2.0",
"eslint-plugin-import": "2.29.1",
"eslint-plugin-jest": "27.9.0",
"eslint-plugin-jsx-a11y": "6.8.0",
"eslint-plugin-react": "7.34.0",
"eslint-plugin-import": "2.29.0",
"eslint-plugin-jest": "27.6.0",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-react": "7.33.0",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-storybook": "0.8.0",
"eslint-plugin-testing-library": "6.2.0",
"eslint-plugin-unicorn": "51.0.1",
"eslint-plugin-storybook": "0.6.12",
"eslint-plugin-testing-library": "6.1.0",
"eslint-plugin-unicorn": "49.0.0",
"eventsourcemock": "2.0.0",
"express": "4.18.2",
"jest": "29.6.2",
Expand Down
Loading