Skip to content

Conversation

kylecarbs
Copy link
Member

The Terraform Provisioner depended on the statefile content
being at a specific path, which disallowed the use of external
state providers. This fixes it!

@kylecarbs kylecarbs requested a review from coadler May 1, 2022 18:08
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1242 (77a01c6) into main (b948f2d) will increase coverage by 0.10%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   65.87%   65.97%   +0.10%     
==========================================
  Files         272      272              
  Lines       17886    17780     -106     
  Branches      192      216      +24     
==========================================
- Hits        11783    11731      -52     
+ Misses       4877     4829      -48     
+ Partials     1226     1220       -6     
Flag Coverage Δ
unittest-go-macos-latest 53.41% <0.00%> (+0.06%) ⬆️
unittest-go-postgres- 64.96% <85.71%> (+0.15%) ⬆️
unittest-go-ubuntu-latest 55.82% <85.71%> (+0.21%) ⬆️
unittest-go-windows-2022 ?
unittest-js 70.69% <ø> (+0.72%) ⬆️
Impacted Files Coverage Δ
provisioner/terraform/provision.go 72.30% <85.71%> (+0.90%) ⬆️
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
cli/configssh.go 62.04% <0.00%> (-5.87%) ⬇️
pty/ptytest/ptytest.go 86.95% <0.00%> (-4.35%) ⬇️
cli/templateinit.go 58.62% <0.00%> (-3.45%) ⬇️
peer/channel.go 84.39% <0.00%> (-2.32%) ⬇️
agent/agent.go 64.12% <0.00%> (-1.51%) ⬇️
coderd/workspaceagents.go 56.04% <0.00%> (-0.73%) ⬇️
site/src/theme/palettes.ts 100.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b948f2d...77a01c6. Read the comment docs.

@kylecarbs kylecarbs self-assigned this May 1, 2022
The Terraform Provisioner depended on the statefile content
being at a specific path, which disallowed the use of external
state providers. This fixes it!
@kylecarbs kylecarbs enabled auto-merge (squash) May 2, 2022 15:32
@kylecarbs kylecarbs merged commit d139a16 into main May 2, 2022
@kylecarbs kylecarbs deleted the remotestate branch May 2, 2022 15:41
kylecarbs added a commit that referenced this pull request Jun 10, 2022
The Terraform Provisioner depended on the statefile content
being at a specific path, which disallowed the use of external
state providers. This fixes it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants