fix: improve pagination parser #12422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11795
This PR improves pagination logic to prevent HTTP 500s caused by PostgreSQL errors.
Before
URL: http://localhost:3000/api/v2/workspaces?limit=1&offset=1000000000000
Reply:
{"message":"Internal error fetching workspaces.","detail":"pq: OFFSET must not be negative"}URL: http://localhost:3000/api/v2/workspaces?limit=1000000000000&offset=-2
Reply:
{"message":"Internal error fetching workspaces.","detail":"pq: OFFSET must not be negative"}URL: http://localhost:3000/api/v2/workspaces?limit=1&offset=991000000000000
Reply:
{"workspaces":[],"count":2}// This one works in a weird way :)After
URL: http://localhost:3000/api/v2/workspaces?limit=1000000000000&offset=-2
Reply:
{"message":"Query parameters have invalid values.","validations":[{"field":"limit","detail":"Query param \"limit\" must be a valid 32-bit positive integer (strconv.ParseInt: parsing \"1000000000000\": value out of range)"},{"field":"offset","detail":"Query param \"offset\" must be a valid 32-bit positive integer (value is negative)"}]}URL: http://localhost:3000/api/v2/workspaces?limit=1&offset=2147483648
Reply:
{"message":"Query parameters have invalid values.","validations":[{"field":"offset","detail":"Query param \"offset\" must be a valid 32-bit positive integer (strconv.ParseInt: parsing \"2147483648\": value out of range)"}]}