Skip to content

chore(coderd): add tests for big oidc tokens #12424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 5, 2024

  • Adds two test cases for a 64k+ ID token and a 64k+ userinfo payload.
  • Unfortunately it then wanted me to reformat the entire test cases array.

@johnstcn johnstcn self-assigned this Mar 5, 2024
@johnstcn johnstcn marked this pull request as ready for review March 5, 2024 11:46
@johnstcn johnstcn requested review from mafredri and Emyrk March 5, 2024 11:46
@MrPeacockNLB
Copy link
Contributor

this is an common error in most enterprise products! Good catch

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests passed? Sweet 👍

@johnstcn johnstcn merged commit 4343998 into main Mar 5, 2024
@johnstcn johnstcn deleted the cj/test-large-oidc-token branch March 5, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants