Skip to content

fix: Remove unnecessary warnings on SSH #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2022
Merged

fix: Remove unnecessary warnings on SSH #1243

merged 1 commit into from
May 2, 2022

Conversation

kylecarbs
Copy link
Member

This disables the "Warning: Permanently added 'hostname' (RSA) to the list of known hosts."
message from appearing on every SSH. This happens because we ignore the known hosts.

This disables the "Warning: Permanently added 'hostname' (RSA) to the list of known hosts."
message from appearing on every SSH. This happens because we ignore the known hosts.
@kylecarbs kylecarbs requested a review from coadler May 1, 2022 18:12
@kylecarbs kylecarbs self-assigned this May 1, 2022
@kylecarbs kylecarbs requested a review from deansheather May 1, 2022 18:12
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1243 (bd738fd) into main (b948f2d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1243      +/-   ##
==========================================
- Coverage   65.79%   65.77%   -0.02%     
==========================================
  Files         272      272              
  Lines       17886    17889       +3     
  Branches      192      192              
==========================================
- Hits        11768    11767       -1     
- Misses       4889     4890       +1     
- Partials     1229     1232       +3     
Flag Coverage Δ
unittest-go-macos-latest 53.22% <100.00%> (+<0.01%) ⬆️
unittest-go-postgres- 64.71% <100.00%> (-0.09%) ⬇️
unittest-go-ubuntu-latest 55.60% <100.00%> (-0.01%) ⬇️
unittest-go-windows-2022 52.81% <100.00%> (+<0.01%) ⬆️
unittest-js 69.96% <ø> (ø)
Impacted Files Coverage Δ
cli/configssh.go 68.61% <100.00%> (+0.70%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
coderd/provisionerdaemons.go 62.28% <0.00%> (-1.02%) ⬇️
coderd/workspaceagents.go 55.84% <0.00%> (-0.94%) ⬇️
provisioner/terraform/provision.go 70.96% <0.00%> (-0.44%) ⬇️
provisionerd/provisionerd.go 76.84% <0.00%> (-0.27%) ⬇️
agent/agent.go 66.87% <0.00%> (+1.25%) ⬆️
peer/conn.go 77.17% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b948f2d...bd738fd. Read the comment docs.

@kylecarbs kylecarbs merged commit 34dbca7 into main May 2, 2022
@kylecarbs kylecarbs deleted the disablesshlog branch May 2, 2022 01:31
kylecarbs added a commit that referenced this pull request Jun 10, 2022
This disables the "Warning: Permanently added 'hostname' (RSA) to the list of known hosts."
message from appearing on every SSH. This happens because we ignore the known hosts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants