Skip to content

fix: allow proxy version mismatch (with warning) #12433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2024
Merged

fix: allow proxy version mismatch (with warning) #12433

merged 4 commits into from
Mar 20, 2024

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Mar 5, 2024 •
edited
Loading

  • Removes version check from register endpoint which causes proxies to enter crash loop backoff
  • ProxyHealth already checks versions and reports them as warnings
  • The proxy now prints a warning on startup if the version doesn't match

TODO:

  • Manually test

@deansheather deansheather requested a review from Emyrk March 5, 2024 19:25
Emyrk
Emyrk approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. The strict version checking was overkill.

@github-actions github-actions bot added the stale This issue is like stale bread. label Mar 13, 2024
@github-actions github-actions bot closed this Mar 17, 2024
@deansheather deansheather reopened this Mar 18, 2024
@deansheather deansheather removed the stale This issue is like stale bread. label Mar 18, 2024
@deansheather
Copy link
Member Author

Version mismatch:
image

2024-03-18 13:33:49.669 [warn]  workspace proxy version doesn't match Minor.Major version of the primary, please keep them in sync  primary_version=v2.8.0-devel+5e01b030a  proxy_version=v1.10.0

Version match:
image

In both cases still selectable from the UI.

@deansheather deansheather requested a review from Emyrk March 18, 2024 14:19
@deansheather deansheather enabled auto-merge (squash) March 20, 2024 07:41
@deansheather deansheather merged commit 2b773f9 into main Mar 20, 2024
@deansheather deansheather deleted the dean/allow-mismatched-proxy-versions branch March 20, 2024 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deansheather @Emyrk