chore(site): add storybook for terminal page #12441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-web-term-notifications
code-asher
approved these changes
Mar 6, 2024
|
|
||
| // Runs when the last event listener is added | ||
| clearTimeout(callEventsDelay); | ||
| callEventsDelay = window.setTimeout(() => { |
There was a problem hiding this comment.
Out of curiosity, why do we need the timeout? I think it makes sense since it allows us to make sure all the listeners are hooked up first but was there a bug with how it was before?
There was a problem hiding this comment.
Yes, the problem with the previous implementation is that it did not respect the order of the events so if the error listener was defined before it would call it first even if it was the third event in the list for example.
Co-authored-by: Asher <ash@coder.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.