Skip to content

chore: add stories for Loader #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2024
Merged

chore: add stories for Loader #12445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9164513
chore: add stories for `Loader`
aslilac Mar 6, 2024
3748a49
🧼
aslilac Mar 6, 2024
d6000f8
let's try this I guess
aslilac Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
🧼
  • Loading branch information
@aslilac
aslilac committed Mar 6, 2024
commit 3748a494294b7da67845ca8d05fdec7774c193f4
6 changes: 3 additions & 3 deletions site/src/components/ErrorBoundary/RuntimeErrorState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ export const RuntimeErrorState: FC<RuntimeErrorStateProps> = ({ error }) => {
<Helmet>
<title>Something went wrong...</title>
</Helmet>
{!checkingError ? (
{checkingError ? (
<Loader fullscreen />
) : (
<Margins css={styles.root}>
<div css={{ width: "100%" }}>
<CoderIcon css={styles.logo} />
Expand Down Expand Up @@ -109,8 +111,6 @@ export const RuntimeErrorState: FC<RuntimeErrorStateProps> = ({ error }) => {
)}
</div>
</Margins>
) : (
<Loader fullscreen />
)}
</>
);
Expand Down
6 changes: 3 additions & 3 deletions site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ export const TemplateVersionEditorPage: FC = () => {
<title>{pageTitle(`${templateName} · Template Editor`)}</title>
</Helmet>

{templateQuery.data && templateVersionQuery.data && fileTree ? (
{!(templateQuery.data && templateVersionQuery.data && fileTree) ? (
<Loader fullscreen />
) : (
<TemplateVersionEditor
activePath={activePath}
onActivePathChange={onActivePathChange}
Expand Down Expand Up @@ -223,8 +225,6 @@ export const TemplateVersionEditorPage: FC = () => {
setProvisionerTags(tags);
}}
/>
) : (
<Loader fullscreen />
)}
</>
);
Expand Down