fix: do not set max deadline for workspaces on template update #12446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When templates are updated and schedule data is changed, we update all running workspaces to have up-to-date scheduling information that sticks to the new policy. When updating the max_deadline for existing running workspaces, if the max_deadline was before now()+2h we would set the max_deadline to now()+2h. Builds that don't/shouldn't have a max_deadline have it set to 0, which is always before now()+2h, and thus would always have the max_deadline updated.
added a user without quiet hours and a template without a autostop requirment to trigger the bug.
Emyrk
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
I've added unit tests that fail on main reproducing the bug.
In practice (I have not manually confirmed), I think these are the steps to reproduce.
- Template autostart requirements must be disabled. This if condition needs to be falsy
- You need to have a workspace that has a deadline beyond 2hrs in the future using said template.
- Update the template schedule (use max ttl should be off)
- Workspace deadline should now be 2hrs after the template
updated_at
Test:
coder/enterprise/coderd/schedule/template_test.go
Lines 135 to 154 in 295b755
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When templates are updated and schedule data is changed, we update all running workspaces to have up-to-date scheduling information that sticks to the new policy.
When updating the
max_deadlinefor existing running workspaces, if themax_deadlinewas beforenow()+2hwe would set themax_deadlinetonow()+2h.Builds that don't/shouldn't have a
max_deadlinehave it set to0, which is always beforenow()+2h, and thus would always have themax_deadlineupdated.Closes https://github.com/coder/customers/issues/530