feat(support): add template info to support bundle #12451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71fea47 to
7c6be17
Compare
7c6be17 to
2d495c2
Compare
johnstcn
commented
Mar 7, 2024
Comment on lines
+148
to
+149
| zipBytes[2] = 0o5 | ||
| zipBytes[3] = 0o6 |
There was a problem hiding this comment.
note: the formatter made these octal of its own volition; likely due to the leading 0.
johnstcn
commented
Mar 7, 2024
| @@ -114,7 +114,6 @@ func assertBundleContents(t *testing.T, path string) { | |||
| require.NoError(t, err, "open zip file") | |||
| defer r.Close() | |||
| for _, f := range r.File { | |||
| require.NotZero(t, f.UncompressedSize64, "file %q should not be empty", f.Name) | |||
There was a problem hiding this comment.
note: removing this as it's redundant with other checks
mtojek
reviewed
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Emyrk raised that this would potentially be helpful for debugging certain types of workspace-related issues.
NOTE: there is currently an issue with how we generate ZIP files from TAR files. Fixing in a separate PR.