Skip to content

chore: add stories for MoreMenu #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 8, 2024
Merged

chore: add stories for MoreMenu #12464

merged 4 commits into from
Mar 8, 2024

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Mar 7, 2024

Part of #11420
Part of #12261

@aslilac aslilac requested review from a team and Parkreiner and removed request for a team March 7, 2024 23:24
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Have one other question with the story output itself, but if you don't think it'll be a problem for now, I can approve

@Parkreiner
Copy link
Member

Parkreiner commented Mar 8, 2024

There's something a little weird happening with the list items, where the indicator for the last-selected item with the arrow keys is visually conflicting with whichever list item is being hovered

Screen.Recording.2024-03-08.at.9.42.18.AM.mov

I don't know what the plan is for the story rollout, so if this isn't a concern for now, I can approve this regardless

My main concern is using Stories to cement functionality we know for a fact is wonky. Though if the Storybook actions are powerful enough, maybe we could include checks for things like this (if not now, then down the line)

@aslilac
Copy link
Member Author

aslilac commented Mar 8, 2024

I've opened an issue (#12482) to track the weird selection state so that we can take care of it later, but for now, since it's already in the app and no one has complained yet, I don't want to block adding the story on fixing it.

@aslilac aslilac requested a review from Parkreiner March 8, 2024 18:45
Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslilac Okay, cool. Approving

@aslilac aslilac merged commit cf4f56d into main Mar 8, 2024
@aslilac aslilac deleted the more-menu-stories branch March 8, 2024 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants