Skip to content

feat: make agent stats' cardinality configurable #12468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 11, 2024
Merged

feat: make agent stats' cardinality configurable #12468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1172e09
Initial implementation
dannykopping Mar 7, 2024
ddd563e
Refactoring
dannykopping Mar 8, 2024
6a1ab6e
Drive-by change to add delve to nix flake so ./scripts/develop.sh --d…
dannykopping Mar 8, 2024
ce0c22d
Update deployment config
dannykopping Mar 8, 2024
25fd616
Linting
dannykopping Mar 8, 2024
cc1a0b0
Control cardinality of coderd metrics as well
dannykopping Mar 8, 2024
122f68d
Remove default value
dannykopping Mar 8, 2024
3e569ff
make fmt && make gen
dannykopping Mar 8, 2024
62e2624
Appeasing CI
dannykopping Mar 8, 2024
6544d2d
Appeasing CI, again...
dannykopping Mar 8, 2024
5e89d05
...
dannykopping Mar 8, 2024
ae8a912
Fix loop var capture
dannykopping Mar 8, 2024
023f7d4
Review comments & CI appeasement
dannykopping Mar 11, 2024
9aedd97
Merge branch 'dk/configurable-cardinality' of github.com:dannykopping…
dannykopping Mar 11, 2024
92be1d6
More review comments & CI appeasement
dannykopping Mar 11, 2024
9b16a3b
Fixing lints
dannykopping Mar 11, 2024
6c7d1bd
Merge branch 'main' of github.com:/coder/coder into dk/configurable-c…
dannykopping Mar 11, 2024
3538e78
chore(dogfood): update keys
johnstcn Mar 11, 2024
5a97817
Merge remote-tracking branch 'upstream/cj/dogfood-update-keys' into d…
dannykopping Mar 11, 2024
c861500
Merge branch 'main' of github.com:/coder/coder into dk/configurable-c…
dannykopping Mar 11, 2024
6bcfe99
Merge branch 'main' of github.com:/coder/coder into dk/configurable-c…
dannykopping Mar 11, 2024
765fe9d
Fix flaky label evaluation by sorting both sides
dannykopping Mar 11, 2024
37c3628
Merge branch 'main' of github.com:/coder/coder into dk/configurable-c…
dannykopping Mar 11, 2024
f1d2821
Update node key
dannykopping Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing lints 
Signed-off-by: Danny Kopping <danny@coder.com>
  • Loading branch information
@dannykopping
dannykopping committed Mar 11, 2024
commit 9b16a3b57a85fbab085103375daabdfb7ec4be2c
2 changes: 1 addition & 1 deletion coderd/agentmetrics/labels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (

const (
LabelAgentName = "agent_name"
LabelUsername = "username"
LabelTemplateName = "template_name"
LabelUsername = "username"
LabelWorkspaceName = "workspace_name"
)

Expand Down
7 changes: 6 additions & 1 deletion coderd/agentmetrics/labels_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,14 @@ package agentmetrics_test
import (
"testing"

"github.com/coder/coder/v2/coderd/agentmetrics"
"github.com/stretchr/testify/require"

"github.com/coder/coder/v2/coderd/agentmetrics"
)

func TestValidateAggregationLabels(t *testing.T) {
t.Parallel()

tests := []struct {
name string
labels []string
Expand Down Expand Up @@ -36,6 +39,8 @@ func TestValidateAggregationLabels(t *testing.T) {
}

for _, tc := range tests {
tc := tc

t.Run(tc.name, func(t *testing.T) {
t.Parallel()

Expand Down