Skip to content

chore(site): add CreateTokenPage story #12472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

BrunoQuaresma
Copy link
Collaborator

FYI: Tried to run a few scenarios but it was failing for me when trying to spy on the API methods. Opened a bug on Storybook repo: storybookjs/storybook#26386

Related to #12263

@BrunoQuaresma BrunoQuaresma requested a review from aslilac March 8, 2024 12:36
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 8, 2024
@aslilac
Copy link
Member

aslilac commented Mar 8, 2024

Could you just specify parameters.queries on the individual stories instead of spying/mocking?

@@ -21,6 +22,8 @@ import {
customLifetimeDay,
} from "./utils";

dayjs.extend(utc);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen Storybook catch so many of these "depending on a dayjs plugin that we don't actually install locally" bugs. 🐛

Copy link
Collaborator Author

Could you just specify parameters.queries on the individual stories instead of spying/mocking?

They don't work for mutations 😥

Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, right. fair enough!

@BrunoQuaresma BrunoQuaresma merged commit 83af867 into main Mar 11, 2024
@BrunoQuaresma BrunoQuaresma deleted the bq/add-stories-create-token-page branch March 11, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants